forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation script cleanup and fixes - Part 1 #3185
Merged
DizzyEggg
merged 12 commits into
rh-hideout:upcoming
from
AsparagusEduardo:RHH/pr/upcoming/animCleanup1
Jul 31, 2023
Merged
Animation script cleanup and fixes - Part 1 #3185
DizzyEggg
merged 12 commits into
rh-hideout:upcoming
from
AsparagusEduardo:RHH/pr/upcoming/animCleanup1
Jul 31, 2023
Commits on Jul 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fee66f0 - Browse repository at this point
Copy the full SHA fee66f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca9e5bf - Browse repository at this point
Copy the full SHA ca9e5bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d247d - Browse repository at this point
Copy the full SHA 68d247dView commit details -
Fixed: createvisualtask SoundTask_PlayCryWithEcho
Checksum changed from 7a05d0b5b2cd65346597a9a598c7f7cde1570475 to 35eae7f4357391b1ce38f0d79715f47f92c82087
Configuration menu - View commit details
-
Copy full SHA for 6c19b35 - Browse repository at this point
Copy the full SHA 6c19b35View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd84fd - Browse repository at this point
Copy the full SHA dcd84fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07c010f - Browse repository at this point
Copy the full SHA 07c010fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2cdf73 - Browse repository at this point
Copy the full SHA d2cdf73View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb2d760 - Browse repository at this point
Copy the full SHA fb2d760View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdcda7f - Browse repository at this point
Copy the full SHA bdcda7fView commit details -
Removed bad use of: createvisualtask AnimTask_Splash in Move_ROCK_CLIMB
It wasn't breaking the animation because ANIM_ATTACKER (0) was being passed for the hop count, essentially skipping the animation.
Configuration menu - View commit details
-
Copy full SHA for 7a9e489 - Browse repository at this point
Copy the full SHA 7a9e489View commit details -
Cleaned: createvisualtask AnimTask_ShockWaveProgressingBolt & AnimTas…
…k_ShakeMonInPlace
Configuration menu - View commit details
-
Copy full SHA for c0bb526 - Browse repository at this point
Copy the full SHA c0bb526View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15f55c0 - Browse repository at this point
Copy the full SHA 15f55c0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.