Animation script cleanup and fixes - Part 1 #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checksum changed from 7a05d0b5b2cd65346597a9a598c7f7cde1570475 to 35eae7f4357391b1ce38f0d79715f47f92c82087
It wasn't breaking the animation because ANIM_ATTACKER (0) was being passed for the hop count, essentially skipping the animation.
…k_ShakeMonInPlace
|
(I recommend this to be squashed) |
AsparagusEduardo
changed the title
DizzyEggg
approved these changes
Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up animation script macro usage to use
ANIM_xdefines and convert hex numbers to positive and negative decimals.For these, I used
shasumto make sure it didn't break anything.visiblemonbginvisiblecreatevisualtaskontargetsAnimTask_ShakeMoncreatevisualtaskSoundTask_PlayDoubleCrySoundTask_PlayCryHighPitchAnimTask_WindUpLungeAnimTask_TranslateMonEllipticalRespectSideAnimTask_SwayMonAnimTask_SplashAnimTask_ShockWaveProgressingBoltAnimTask_ShakeMonInPlaceIt also fixes the following bad uses of macros (original checksum:
7a05d0b5b2cd65346597a9a598c7f7cde1570475)createvisualtaskSoundTask_PlayCryWithEcho(checksum changed to35eae7f4357391b1ce38f0d79715f47f92c82087) in:AnimTask_Splash(checksum changed to99dd16cb37b2e592c80ee16f740c672fa511336d) in:AnimTask_ShockWaveProgressingBolt(checksum changed to774f3ef2f9ec10c740b4e6f45fa64167c13baa8b) in:Discord contact info
asparaguseduardo