-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clear Amulet visual bug + Tests #3074
Fix Clear Amulet visual bug + Tests #3074
Conversation
TODO Tests, additional tests + Triple Kick pp bug
f116e34
to
c6b206c
Compare
Added all the TODO tests, wrote some additional tests for Own Tempo, Inner Focus, Scrappy and added the missing Clear Amulet checks. Also fixed a tiny Triple Kick bug (issue #3054) |
swag |
Please avoid doing force pushes, it makes it harder to tell what was changed in a PR. |
Oh will avoid doing it, sorry. I have done that to have a clean commit history but I understand. |
Something I often do as a PR author is write a message saying that I intend to rebase and force push to clean up the history once the PR is accepted :) |
Good suggestion! 👍 |
Even then, if it's intended to be a single commit, we can squash it ourselves upon merging thanks to GitHub's Squash and Merge option :) |
Added the Wonder Guard message, changed if to switch and fixed misalignment. |
Description
Fixes Clear Amulet visual bug. A wrong message was displayed when Intimidate on Clear Amulet was used.
Also removed some code in the Intimidate script that was not needed and added a couple of tests.
**Issue(s) that this PR fixes **
Fixes #3054
Discord contact info
rainonline