Conversation
|
Warning Review limit reached
Next review available in: 29 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
WalkthroughThe OSAC plugin adds BCM inventory settings, schema validation, image defaults, and conditional bootstrap rendering. It also renders discovery-agent host metadata and BCM-agent mTLS settings. ChangesOSAC BCM integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/osac/defaults.yaml`:
- Around line 47-50: Replace the mutable latest tags in operator_tag,
fulfillment_service, and aap_bootstrap with approved version-pinned tags or
immutable image digests. Keep the existing image repositories unchanged and
ensure all three defaults resolve to reproducible binaries.
- Around line 45-51: Rename the osac_images.operator and
osac_images.operator_tag defaults to the schema and template key osac_operator,
using a single complete operator image reference. Preserve the existing operator
image repository and latest tag while removing the obsolete split fields so the
default override is rendered correctly.
In `@plugins/osac/schemas/config.yaml`:
- Around line 132-157: Update the schema validation for osacBcmEnabled so that
when it is true, osacBcmApiUrl, osacBcmClientCert, and osacBcmClientKey are each
required and non-empty. Preserve the existing optional behavior when BCM is
disabled, using the schema’s conditional validation mechanism.
In `@plugins/osac/templates/values.yaml.j2`:
- Around line 123-143: Update the `_has_discovery` condition in the values
template to require both a non-empty `discovery_hosts` list and `'caas' in
osacProfilesList`; use this gated value for the existing `importAgentsEnabled`
and `importAgents` blocks. Keep the BMAAS handling via `_has_bcm` unchanged.
- Around line 117-152: Update the YAML structure in the values template so
configAsCode, importAgents, importBcmAgents, bmf, and their related enable flags
are all nested under aap.bootstrap. Preserve the existing conditional rendering
and values while correcting indentation for the entire bootstrap configuration.
- Around line 144-150: Extend the _has_bcm block in the values.yaml.j2 template
to render the remaining BCM connection settings alongside importBcmAgents.cert
and importBcmAgents.key. Map osacBcmApiUrl, osacBcmValidateCerts, and
osacBcmDisableBmcCertVerification to their supported BCM-agent values fields,
preserving the existing conditional and YAML formatting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8f0c30e5-467f-4ecb-8e5a-0ee2c8a55319
📒 Files selected for processing (4)
config/plugins/osac.example.yamlplugins/osac/defaults.yamlplugins/osac/schemas/config.yamlplugins/osac/templates/values.yaml.j2
0cee31f to
6781622
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
6781622 to
840fd9c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/osac/templates/values.yaml.j2`:
- Around line 135-141: Update the host fields in the values template, including
bmc_url, credentials, boot_mac, netris_server_name, and resource_class, to
serialize their dynamic Jinja values as YAML-safe scalars before rendering.
Preserve the existing values and defaults while ensuring quotes, special
characters, and newlines cannot produce invalid values.yaml output.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fbb6dcf1-9916-4be0-a2b5-322bf4ffdcea
📒 Files selected for processing (5)
config/plugins/osac.example.yamlplugins/osac/defaults.yamlplugins/osac/schemas/config.yamlplugins/osac/schemas/defaults.yamlplugins/osac/templates/values.yaml.j2
Add BCM (NVIDIA Base Command Manager) as an optional bare metal inventory source alongside the existing discovery_hosts. Schema: osacBcmEnabled toggle, API URL, mTLS client cert/key, cert validation settings. Conditional validation requires connection fields when BCM is enabled. Defaults: BCM disabled, safe defaults for all fields. Container image defaults for OSAC operator, fulfillment-service, envoy, bootstrap, and CLI. Template: renders discovery-agent imports from discovery_hosts when CaaS profile is active. Enables BCM import with full connection settings when osacBcmEnabled is set. Both inventory sources can run simultaneously. Assisted-by: Claude Code <noreply@anthropic.com>
840fd9c to
ae0c560
Compare
|
/retest |
|
Re-triggered failed runs:
|
1 participant
Add BCM (NVIDIA Base Command Manager) as an optional bare metal inventory source alongside the existing discovery_hosts.
Assisted-by: Claude Code noreply@anthropic.com
Summary by CodeRabbit