Skip to content

OSAC-1602: add configurable CaaS inventory backend - #615

Closed
rccrdpccl wants to merge 1 commit into
rh-ecosystem-edge:mainfrom
rccrdpccl:feat/OSAC-1602-inventory-backend
Closed

rccrdpccl wants to merge 1 commit into
rh-ecosystem-edge:mainfrom
rccrdpccl:feat/OSAC-1602-inventory-backend

Conversation

@rccrdpccl

Copy link
Copy Markdown
Contributor

Add BCM (NVIDIA Base Command Manager) as an optional bare metal inventory source alongside the existing discovery_hosts.

  • Schema: osacBcmEnabled toggle, API URL, mTLS client cert/key, cert validation settings. Uses title/format/enumLabels for schema-driven UI rendering.
  • Defaults: BCM disabled, safe defaults for all fields.
  • Template: derives ConfigMap import-agents from discovery_hosts when CaaS profile is active. Enables BCM import when osacBcmEnabled is set. Both can run simultaneously.

Assisted-by: Claude Code noreply@anthropic.com

@rccrdpccl
rccrdpccl requested a review from eurijon July 22, 2026 12:57
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rccrdpccl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a6aa06b4-121d-43c1-a88e-eb9763991b2b

📥 Commits

Reviewing files that changed from the base of the PR and between 1099045 and 5e74348.

📒 Files selected for processing (4)
  • config/plugins/osac.example.yaml
  • plugins/osac/defaults.yaml
  • plugins/osac/schemas/config.yaml
  • plugins/osac/templates/values.yaml.j2
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Add BCM (NVIDIA Base Command Manager) as an optional bare metal
inventory source alongside the existing discovery_hosts.

- Schema: osacBcmEnabled toggle, API URL, mTLS client cert/key,
  cert validation settings. Uses title/format/enumLabels for
  schema-driven UI rendering.
- Defaults: BCM disabled, safe defaults for all fields.
- Template: derives ConfigMap import-agents from discovery_hosts
  when CaaS profile is active. Enables BCM import when
  osacBcmEnabled is set. Both can run simultaneously.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Riccardo Piccoli <rpiccoli@redhat.com>
@rccrdpccl
rccrdpccl force-pushed the feat/OSAC-1602-inventory-backend branch from bc3981b to 5e74348 Compare July 22, 2026 13:04
@eurijon

eurijon commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@rccrdpccl please create the PR from a branch, otherwise the CI jobs won't work

@rccrdpccl

Copy link
Copy Markdown
Contributor Author

#626

@rccrdpccl rccrdpccl closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Deployment-related changes plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants