Skip to content

Remove gemini dependency from eval tests #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omertuc merged 1 commit into from
Oct 27, 2025
Merged

Remove gemini dependency from eval tests #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions scripts/ci_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ if ! oc get secret -n "$NAMESPACE" assisted-chat-ssl-ci &>/dev/null; then
--from-file=client_secret="${SECRETS_BASE_PATH}/sso-ci/client_secret"
fi

if ! oc get secret -n "$NAMESPACE" gemini &>/dev/null; then
echo "Creating gemini secret in namespace $NAMESPACE"
oc create secret generic -n $NAMESPACE gemini --from-file=api_key="${SECRETS_BASE_PATH}/gemini/api_key"
fi

oc process -p IMAGE_NAME="$ASSISTED_CHAT_TEST" \
-p SSL_CLIENT_SECRET_NAME=assisted-chat-ssl-ci \
-p JOB_ID=${UNIQUE_ID} \
Expand Down
1 change: 0 additions & 1 deletion test/evals/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Evaluation mechanism to validate Agent task completion (e2e)
```bash
pip install git+https://github.com/lightspeed-core/lightspeed-evaluation.git#subdirectory=lsc_agent_eval
```
- `GEMINI_API_KEY` env var is set

## Running tests

Expand Down
9 changes: 0 additions & 9 deletions test/prow/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ objects:
secretKeyRef:
key: ${SSL_CLIENT_SECRET_KEY}
name: ${SSL_CLIENT_SECRET_NAME}
- name: GEMINI_API_KEY
valueFrom:
secretKeyRef:
key: ${GEMINI_API_SECRET_KEY_NAME}
name: ${GEMINI_API_SECRET_NAME}
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /opt/app-root/google-vertex-service-account.json
- name: AGENT_URL
Expand Down Expand Up @@ -72,10 +67,6 @@ parameters:
value: http://assisted-chat
- name: AGENT_PORT
value: "8090"
- name: GEMINI_API_SECRET_NAME
value: gemini
- name: GEMINI_API_SECRET_KEY_NAME
value: api_key
- name: VERTEX_API_SECRET_NAME
value: vertex-service-account
- name: VERTEX_API_SECRET_KEY_NAME
Expand Down