Skip to content

Conversation

@omertuc
Copy link
Member

@omertuc omertuc commented Oct 27, 2025

The eval tests should only rely on Vertex, not Gemini

The goal is to get openshift/release#68483 to finally pass.

Summary by CodeRabbit

  • Chores
    • Removed Gemini API key environment variable and all associated secret management parameters from continuous integration and test infrastructure setup processes
    • Simplified CI pipeline configuration by eliminating Gemini API key-related initialization, dependencies, and secret creation logic throughout the system
    • Updated test documentation to reflect the removal of Gemini API key configuration requirements and related references

The eval tests should only rely on Vertex, not Gemini

The goal is to get openshift/release#68483 to
finally pass.
@openshift-ci openshift-ci bot requested review from jhernand and maorfr October 27, 2025 13:25
@omertuc
Copy link
Member Author

omertuc commented Oct 27, 2025

/hold I want to see the eval-test run (doesn't need to pass)

@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2025

Walkthrough

Removal of Gemini API key configuration from CI and test infrastructure. Changes include deletion of the gemini secret creation block in the CI test script, removal of GEMINI_API_KEY environment variable and related parameters from the Prow template, and documentation update reflecting these removals.

Changes

Cohort / File(s) Change Summary
Gemini configuration removal
scripts/ci_test.sh
Removed conditional gemini secret creation block (check for secret existence and creation from SECRETS_BASE_PATH)
Gemini configuration removal
test/evals/README.md
Removed documentation line indicating GEMINI_API_KEY environment variable is set
Gemini configuration removal
test/prow/template.yaml
Removed GEMINI_API_KEY environment variable from Job container definition; removed GEMINI_API_SECRET_NAME and GEMINI_API_SECRET_KEY_NAME parameters

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • All changes are straightforward removals of Gemini-related configuration
  • Homogeneous pattern across files reduces cognitive load
  • Minimal logic complexity; primarily configuration/documentation changes

Possibly related PRs

Suggested reviewers

  • eranco74
  • carbonin
  • keitwb

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Remove gemini dependency from eval tests" directly and accurately describes the primary changes in the changeset. All three modified files (scripts/ci_test.sh, test/evals/README.md, and test/prow/template.yaml) contain changes that remove Gemini-related configurations, environment variables, and secret creation logic from the eval test infrastructure. The title is concise, specific, and uses clear language that would help a teammate quickly understand the main change when scanning PR history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 662cbf3 and 0fbc57a.

📒 Files selected for processing (3)
  • scripts/ci_test.sh (0 hunks)
  • test/evals/README.md (0 hunks)
  • test/prow/template.yaml (0 hunks)
💤 Files with no reviewable changes (3)
  • scripts/ci_test.sh
  • test/prow/template.yaml
  • test/evals/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
  • GitHub Check: Red Hat Konflux / assisted-chat-test-image-saas-main-on-pull-request

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

@omertuc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/eval-test 0fbc57a link false /test eval-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@omertuc
Copy link
Member Author

omertuc commented Oct 27, 2025

/unhold Looks good

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc omertuc merged commit 9dc8780 into rh-ecosystem-edge:main Oct 27, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants