-
Notifications
You must be signed in to change notification settings - Fork 21
Remove gemini dependency from eval tests #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The eval tests should only rely on Vertex, not Gemini The goal is to get openshift/release#68483 to finally pass.
|
/hold I want to see the eval-test run (doesn't need to pass) |
WalkthroughRemoval of Gemini API key configuration from CI and test infrastructure. Changes include deletion of the gemini secret creation block in the CI test script, removal of GEMINI_API_KEY environment variable and related parameters from the Prow template, and documentation update reflecting these removals. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@omertuc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/unhold Looks good |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The eval tests should only rely on Vertex, not Gemini
The goal is to get openshift/release#68483 to finally pass.
Summary by CodeRabbit