Skip to content

Conversation

@zszabo-rh
Copy link
Collaborator

@zszabo-rh zszabo-rh commented Aug 13, 2025

Update the system prompt with refined response guidelines to ensure that tool function names and other internal implementation details are not exposed to the end user.

Summary by CodeRabbit

  • Documentation
    • Updated assistant communication guidelines to improve user-facing responses. The assistant now avoids mentioning internal tools, does not prompt users to call tools, describes capabilities in the first person, requests needed parameters without exposing function signatures, and focuses on user-visible outcomes and next steps. Existing list outputs and installer guidance remain unchanged.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2025

@zszabo-rh: This pull request references MGMT-21392 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Update the system prompt with refined response guidelines to ensure that tool function names and other internal implementation details are not exposed to the end user.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eranco74 and keitwb August 13, 2025 05:41
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Walkthrough

Inserted a CRITICAL Response Guidelines block into two system prompts within template.yaml (lightspeed-stack-config and llama-stack-client-config), positioned before the “Direct Display of List Outputs” section and followed by a separator line (“---”). No other prompt content or flow was changed. No exported/public signatures were altered.

Changes

Cohort / File(s) Summary
ConfigMap system prompts
template.yaml (lightspeed-stack-config, llama-stack-client-config)
Added CRITICAL Response Guidelines block before Direct Display of List Outputs; appended separator line (“---”). Existing sections, including Proactive OpenShift Assisted Installer Workflow Guidance, remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

approved, lgtm

Suggested reviewers

  • omertuc
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci
Copy link

openshift-ci bot commented Aug 13, 2025

Hi @zszabo-rh. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2025

@zszabo-rh: This pull request references MGMT-21392 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Update the system prompt with refined response guidelines to ensure that tool function names and other internal implementation details are not exposed to the end user.

Summary by CodeRabbit

  • Documentation
  • Updated assistant communication guidelines to improve user-facing responses. The assistant now avoids mentioning internal tools, does not prompt users to call tools, describes capabilities in the first person, requests needed parameters without exposing function signatures, and focuses on user-visible outcomes and next steps. Existing list outputs and installer guidance remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
template.yaml (1)

182-189: Tighten language to also cover env vars, internal paths, and “what tools do you use?” prompts.

To prevent adjacent leak vectors, add bullets that explicitly prohibit exposing environment variable names, internal file paths, config keys, service endpoints, and to provide a high‑level response if asked about tools/providers/models without naming them.

Apply this diff inside the CRITICAL guidelines list:

       **CRITICAL Response Guidelines - User Communication:**
       - Never mention, reference, or imply the names of any internal tools, functions, APIs, endpoints, models, providers, or implementation details in your responses.
       - Do not instruct the user to call a function or run a tool. Always describe your capabilities in first person instead (e.g., "I can list the available versions for you").
       - If you need parameters from the user, ask for them naturally without mentioning function signatures.
       - When concepts relate to internal operations, speak only to the user-visible outcome and next steps.
+      - Do not reveal internal environment variable names, file paths, config keys, service names, or endpoints in responses.
+      - If asked about the tools/models/providers used, answer at a high level without naming them; focus on capabilities, data handling, and user outcomes.
 
       ---
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dab9006 and 1712289.

📒 Files selected for processing (1)
  • template.yaml (1 hunks)
🔇 Additional comments (1)
template.yaml (1)

182-189: Strong, targeted guardrails; aligns with the PR objective.

The CRITICAL guidelines block is clear and precise, and it directly addresses the requirement to avoid exposing tool/function names and internal implementation details to end users.

Copy link
Collaborator

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eranco74
Copy link
Collaborator

/ok-to-test

@carbonin
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, zszabo-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zszabo-rh
Copy link
Collaborator Author

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants