-
Notifications
You must be signed in to change notification settings - Fork 22
MGMT-21392: avoid referencing function names #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-21392: avoid referencing function names #123
Conversation
|
@zszabo-rh: This pull request references MGMT-21392 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughInserted a CRITICAL Response Guidelines block into two system prompts within template.yaml (lightspeed-stack-config and llama-stack-client-config), positioned before the “Direct Display of List Outputs” section and followed by a separator line (“---”). No other prompt content or flow was changed. No exported/public signatures were altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @zszabo-rh. Thanks for your PR. I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@zszabo-rh: This pull request references MGMT-21392 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
template.yaml (1)
182-189: Tighten language to also cover env vars, internal paths, and “what tools do you use?” prompts.To prevent adjacent leak vectors, add bullets that explicitly prohibit exposing environment variable names, internal file paths, config keys, service endpoints, and to provide a high‑level response if asked about tools/providers/models without naming them.
Apply this diff inside the CRITICAL guidelines list:
**CRITICAL Response Guidelines - User Communication:** - Never mention, reference, or imply the names of any internal tools, functions, APIs, endpoints, models, providers, or implementation details in your responses. - Do not instruct the user to call a function or run a tool. Always describe your capabilities in first person instead (e.g., "I can list the available versions for you"). - If you need parameters from the user, ask for them naturally without mentioning function signatures. - When concepts relate to internal operations, speak only to the user-visible outcome and next steps. + - Do not reveal internal environment variable names, file paths, config keys, service names, or endpoints in responses. + - If asked about the tools/models/providers used, answer at a high level without naming them; focus on capabilities, data handling, and user outcomes. ---
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
template.yaml(1 hunks)
🔇 Additional comments (1)
template.yaml (1)
182-189: Strong, targeted guardrails; aligns with the PR objective.The CRITICAL guidelines block is clear and precise, and it directly addresses the requirement to avoid exposing tool/function names and internal implementation details to end users.
eranco74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, zszabo-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
2cb8f6c
into
rh-ecosystem-edge:main
Update the system prompt with refined response guidelines to ensure that tool function names and other internal implementation details are not exposed to the end user.
Summary by CodeRabbit