-
Notifications
You must be signed in to change notification settings - Fork 21
MGMT-22329: (fix) Update system prompt to handle large cluster/event list display with client-side paging #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@eranco74: This pull request references MGMT-22329 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@eranco74: This pull request references MGMT-22329 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@eranco74: This pull request references MGMT-22329 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
template.yaml(1 hunks)
🔇 Additional comments (2)
template.yaml (2)
247-262: Paging logic is clear, but relies on context retention across turns.The new paging directive (lines 247–262) introduces a sound strategy for handling large cluster/event lists. The rules are explicit: retain the full list, show the first 10, offer filtering or next-page options, and use the retained list for subsequent slices without re-invoking the tool.
This assumes the chat context persists across multiple turns. In typical conversations this is fine, but if the context window fills and old messages are trimmed, the retained list may be lost and the tool would need to be called again. The prompt does not address this edge case. Consider whether this is acceptable for the expected usage pattern, or whether additional guidance is needed (e.g., "if the full list is no longer in context, call the tool again").
242-262: Paging examples are clear and actionable.The truncation response examples (lines 257–258) for clusters and events are well-structured and give the AI explicit phrasing to follow. The distinction between host lists (no truncation) and cluster/event lists (paging) is also clear.
…list display with client-side paging Prevents the failure to display large cluster and event lists by imposing a 10-item limit via the system prompt. Signed-off-by: Eran Cohen <[email protected]>
|
@eranco74: This pull request references MGMT-22329 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@eranco74: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
So I think this is fine, but can we test it? Also is there any benefit or precedent for doing some kind of paging on the MCP server side? |
This fix Prevents the failure to display large cluster and event lists by imposing a 10-item limit via the system prompt.
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.