Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split the eror-raising part of constructor into separate method. #35

Closed
wants to merge 2 commits into from
Closed

split the eror-raising part of constructor into separate method. #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7802d4d
split the eror-raising part of constructor into separate method.
fathonysl Oct 23, 2024
bb23636
Merge branch 'main' into temp-alwaysfine-constructor
rgrove Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/lib/Parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class Parser {
*/
constructor(xml: string, options: ParserOptions = {}) {
let doc = this.document = new XmlDocument();
let scanner = this.scanner = new StringScanner(xml);
this.scanner = new StringScanner(xml);

this.currentNode = doc;
this.options = options;
Expand All @@ -40,8 +40,12 @@ export class Parser {
doc.start = 0;
doc.end = xml.length;
}

this.startParse();
}

scanner.consumeStringFast('\uFEFF'); // byte order mark
startParse() {
this.scanner.consumeStringFast('\uFEFF'); // byte order mark
this.consumeProlog();

if (!this.consumeElement()) {
Expand All @@ -50,7 +54,7 @@ export class Parser {

while (this.consumeMisc()) {} // eslint-disable-line no-empty

if (!scanner.isEnd) {
if (!this.scanner.isEnd) {
throw this.error('Extra content at the end of the document');
}
}
Expand Down