split the eror-raising part of constructor into separate method.

[x2nie]

Hi !
I found this lib is quite good, but I face a trouble while inherit the Parser class.

My situation is: I want to parse a section of xml (a string, not a whole file), hence it may has several root elements.
Now I want my (inheritance) parser to keep parsing for second root and so.
Ideally, it would be like as:

class MyParser extends Parser {
    //? Allow multiroot
    constructor(xml: string, options: ParserOptions = {}) {
        try {
            super(xml, options);
        } catch (err) {
            // we do not care about multiroot validation here
            if(!(err as Error).message.startsWith('Extra content at the end of the document'))
                throw err; // show non multi-root error
        
            while (!this.scanner.isEnd) {
                this.consumeElement();
                this.consumeMisc();
            }
        }
    }

But that code is invalid; bacause super() can't be called inside try..catch.

Currently, I solve it by copying the whole class and modify the constructor; and yes it works, but it isn't what I want to do.
Modifying some methods (as needed) is the best practice, I think.

So, here the patch to allow the parser to be inherited (especially to not throwing error on constructor).

note:

• I am sorry for my bad english I wish you okay.
• I also pass the tests, and its fine too.
• here a picture below: multi root xml usage in real life (my VS Code notebook project).

[rgrove]

Thanks! This seems reasonable. I should have time to merge it soon.

It looks like I'll need to update the GitHub Actions workflow to fix some problems; the failures there aren't related to this change.

One thing to be aware of if you're extending the Parser class is that this class isn't part of parse-xml's public API, so it may experience breaking changes in minor and patch releases.

[rgrove]

Merged! I renamed the startParse method to parse to be a little less verbose. This will be released in v4.2.0.