-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HTML4 data-* attributes, and replace with is
#21
Comments
revivek
pushed a commit
that referenced
this issue
Jan 27, 2016
revivek
pushed a commit
that referenced
this issue
Jan 27, 2016
revivek
added a commit
that referenced
this issue
Jan 27, 2016
Use `is` attribute to ignore attribute whitelist. Fixes #21
Using Few solutions:
Out of the two, I think #2 is more tenable and future-proof, though involves more code. |
revivek
added a commit
that referenced
this issue
Jan 31, 2016
Revert "Use `is` attribute to ignore attribute whitelist. Fixes #21"
revivek
pushed a commit
that referenced
this issue
Jan 31, 2016
…onents. See #21 for explanation for further namespacing. It should decrease the likelihood of collisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of June 10, 2015, we can remove the
data-*
attributes that get search and replaced (data-bgcolor
,data-align
, etc.) to the HTML4 variants. We can use theis
property. This should also fix an unlikely but still possible bug resulting from the current search and replace strategy: since we operate on the raw string, all of data-background and its cousins would be replaced. This means an HTML5 newsletter writing about how "AlignerFoo.js uses data-align to align your elements" would turn into "AlignerFoo.js uses align to align your elements."facebook/react#140 (comment)
facebook/react#3752
To do:
data-*
attributes fromOyTable
,OyImg
, etc.is
attribute before those removeddata-*
attributes.data-*
attributes inutils/HTML4.js
The text was updated successfully, but these errors were encountered: