Ignore whitelisted attributes for native custom elements.

[jhicken]

#140

This will cause react to ignore the regular props/attributes whitelist if the tag name for an element contains a - or if the element has an is attribute applied to it. This makes you able to use native custom elements via the is attribute or by adding a - your custom element tag name.

I just threw this together real quick. I just want to make sure I'm running down a good path with it.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[zpao]

This has a ton of overlap with #3067, we should probably focus our efforts. cc @JSFB to figure out the best path forward.

[jimfb]

Yeah, let's check the status of #3067 and once we figure out what to do there, we can take another look at this PR.

[jhicken]

sounds good

[jhicken]

So @jimfb 's commit #3067 took care of most of this. We still have one last problem to resolve. When there is an "is" attribute we should be ignoring the whitelist for other attributes on that element. I updated my PR It should take care of this last little problem. @zpao can we look at this again?

[jimfb]

Cool, this looks good to me. 👍

cc @zpao @spicyj Any objections or is this one good to go? (modulo travis build failure)

[sophiebits]

Should be props.is != null. Can we extract the logic to a helper function? (Side note: when is this._tag null?)

Ideally we would do something intelligent when the value of the is attribute changes since I assume we need to remount the element to have things work properly. (That sounds harder though and certainly doesn't need to be done in this PR.)

[jimfb]

Use nextProps here, not props (which is undefined).

[jimfb]

@spicyj Just to confirm, you're looking for a helper function that takes in tag&props to decide if the element is a webcomponent?

[sophiebits]

Yeah. It was more convincing when I thought it could just take this as an argument, but tag and props seems good.

[jhicken]

Is this what yall where thinking?

[jimfb]

Thanks @jhicken! Looks great to me.