Update Item details and Item properties on custom field change #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Item details update when it’s current showing a selection (rather than the playing item) and a custom title formatting field provided by a component (such as Playback Statistics) changes.
This makes Item properties update when a custom title formatting field provided by a component (such as Playback Statistics) changes. Although Item properties doesn’t use title formatting, this change makes the panel update when things like playback statistics change, and makes the behaviour consistent with Default UI.
reupen
force-pushed
the
item-details-props-fromhook
branch
from
8d6fe8c
to
677c572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #903
This makes Item details and Item properties update when a component indicates that a custom title formatting field has changed.
Although Item properties doesn’t use title formatting, this change makes the panel update when things like playback statistics change, and makes the behaviour consistent with Default UI.
In the case of Item details, the change of behaviour is only relevant when it’s currently showing a selection (rather than the playing item) as these updates were already handled for playing items.