Item properties / item details ignoring fromhook

[marc2k3]

columns_ui/foo_ui_columns/item_properties.cpp

Line 619 in e112325

if (!p_fromhook) {

columns_ui/foo_ui_columns/item_details.cpp

Line 511 in e112325

if (!p_fromhook && !m_nowplaying_active) {

Is there a reason for this? It means Playback Statistics / 3rd party components using metadb_index_manager::dispatch_refresh don't see real time updates.

If performance is an issue, maybe loosen it for handle counts of one?

[reupen]

Hmm, definitely wrong for Item details.

Taking the docs at face value, it looks correct for Item properties (as p_fromhook and metadb_display_field_provider are for title formatting). However, Selection Properties in DUI updates when changing ratings using Playback Statistics, so I assume Selection Properties is ignoring the flag (as I'm not sure how else it would be updating...)

[marc2k3]

Hmm, definitely wrong for Item details.

IMHO, Item properties populating Playback Statistics / Other sections using track_property_provider::enumerate gets data from the exact the same place as metadb_display_field_provider so it should respond to on_changed_sorted / p_fromhook as well.

[marc2k3]

Thanks for this.