Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in Item details panel with certain emoji characters #323

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Fix crash in Item details panel with certain emoji characters #323

merged 1 commit into from
Aug 23, 2020

Commits on Aug 23, 2020

  1. Fix crash in Item details panel with certain emoji characters 

    #321

This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered.

These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units.

Word wrapping behaviour will be slightly different to previous versions as a result of these changes.
    @reupen
    reupen committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    2db7d22 View commit details
    Browse the repository at this point in the history