-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sudden Crash with item details #321
Comments
Thanks for the report and repro steps – I've reproduced the problem. It's happening because the Windows API function Items details uses (ScriptString_pcOutChars) to work out how many characters fit in the available space is counting the emojis as two code points each, while I was under impression they were one code point each (but two code units in UTF-16). Other functions in that area of the Windows API (Uniscribe) seem to be doing the same. I'll need to investigate a bit further about how to fix this. But it's affecting those two emojis as their code points in hex are above FFFF. I'd suggest avoiding them for now. |
Hello! Thank you and stay healthy. |
Just a note to say I'm still working on a fix. I've needed to rewrite the word wrapping logic (which is complex due to font and colour code support). Hopefully I'll have something to test in a few days or so. |
Nice to hear. I'll take a look then. |
#321 This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered. These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units. Word wrapping behaviour will be slightly different to previous versions as a result of these changes.
#321 This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered. These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units. Word wrapping behaviour will be slightly different to previous versions as a result of these changes.
#321 This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered. These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units. Word wrapping behaviour will be slightly different to previous versions as a result of these changes.
#321 This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered. These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units. Word wrapping behaviour will be slightly different to previous versions as a result of these changes.
Hi, I have a development version available to test: In that archive, within The crash should be gone, but I'd check that other Item details functionality like Thanks! |
Hello and thanks! thanks for your time :-) |
Thanks for testing! I've put a fix in for the alignment – here's a new version.
|
Thanks for the info about $tab()! Thanks again :-) |
Great. Thanks for testing! |
Hello,
I have the following problem:
'Item detais' with this sequence:
$if($stricmp($left(%path%,4),http),📻,💿 )[%album%[ '('$year(%date%)')']$ifgreater(%totaltracks%,1, `'['%tracknumber%/%totaltracks%']',)]
Often when I click in the Playlist to a untagged file foobar crashes . This does often/but not always happen, and rarely it creates a crash-log.
If I remove the sequence by a "//" I had no mistakes.
annexed rarely crash-logs. I hope they can help.
crash reports.zip
Best regards
Arne
The text was updated successfully, but these errors were encountered: