MultiGP #274
Merged
MultiGP #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it! And I think we can focus on independent GPs. |
OK! I will leave it as is then.. I will merge once the tests pass.. |
|
Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly addresses #266 ... It also removes from default optimizer the parallel_repeater, because in most cases it doesn't improve performance and makes things slower.. Of course, one can use it if he wants..
One thing that I thought while coding it is the following. I created the
MultiGPclass as a template so that one can train the N-GPs as he wishes. On the contrary, I am constraining the querying to the cases where the GPs are independent. Should I provide some functor/functionality to allow for full multi-output GPs? Of course the default case would be the independent version. From an implementation point of you, it is very easy to add it; I am just asking if it makes sense/is worth it? What do you think?