Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static analysis #31

Open
jbmouret opened this issue Nov 1, 2015 · 3 comments
Open

static analysis #31

jbmouret opened this issue Nov 1, 2015 · 3 comments
Assignees

Comments

@jbmouret
Copy link
Member

jbmouret commented Nov 1, 2015

to try: http://clang-analyzer.llvm.org/

@costashatz costashatz self-assigned this Dec 17, 2015
@costashatz
Copy link
Member

I performed a static analysis and I found the following results:

static_analysis

Analyzing them a bit, we can see that we do not really have any trouble in our code except for one minor dead assignment in sys.hpp (which I will remove). There are some warnings/bugs in the ehvi and the hypervol code though. I looked a little bit deeper and the most dangerous one is the memory leak one (as I have noted in the image).

I will fix these 2 issues. The other ones are not that obvious on how to fix, since it is not our code.

Do you have any suggestions on how we can automate this static analysis procedure?

@jbmouret
Copy link
Member Author

Great! Indeed, the issues are not from our code and this would not be easy
to debug. As these are still experimental components, I suggest we do not
anything for now.

I think we should add this to a weekly CI on our cluster (with the full
benchmark and the extensive tests). Ideally, we would post these results on
a mailing list and/or on github.

-- JBM

On Sat, Jul 23, 2016 at 8:31 AM Konstantinos Chatzilygeroudis <
[email protected]> wrote:

I performed a static analysis and I found the following results:

[image: static_analysis]
https://cloud.githubusercontent.com/assets/1283922/17078383/53ebe00a-50f2-11e6-93b6-b43af498e76f.png

Analyzing them a bit, we can see that we do not really have any trouble in
our code except for one minor dead assignment in sys.hpp (which I will
remove). There are some warnings/bugs in the ehvi and the hypervol code
though. I looked a little bit deeper and the most dangerous one is the
memory leak one (as I have noted in the image).

I will fix these 2 issues. The other ones are not that obvious on how to
fix, since it is not our code.

Do you have any suggestions on how we can automate this static analysis
procedure?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFu8v4gDzpWMt-COODmY5S0QFQpAzGI1ks5qYiWwgaJpZM4GZwRZ
.

@costashatz
Copy link
Member

Great! Indeed, the issues are not from our code and this would not be easy
to debug. As these are still experimental components, I suggest we do not
anything for now.

Agreed.

I think we should add this to a weekly CI on our cluster (with the full
benchmark and the extensive tests). Ideally, we would post these results on
a mailing list and/or on github.

OK. I will send you the commands that are needed to run the static analyzer. Although, I would say that the frequency should be bi-weekly not weekly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants