Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Make sure blueprint gets sent to the notebook view being created #7811

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[bugfix] Make sure blueprint gets sent to the notebook view being created #7811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rerun_py/rerun_sdk/rerun/notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ def __init__(

self._recording = recording

if blueprint is not None:
self._recording.send_blueprint(blueprint) # type: ignore[attr-defined]

self._viewer = _Viewer(
width=width if width is not None else _default_width,
height=height if height is not None else _default_height,
Expand All @@ -105,6 +102,9 @@ def __init__(
callback=self._flush_hook,
)

if blueprint is not None:
self._recording.send_blueprint(blueprint) # type: ignore[attr-defined]

def display(self, block_until_ready: bool = True) -> None:
"""
Display the viewer in the notebook cell immediately.
Expand Down
Loading