Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Make sure blueprint gets sent to the notebook view being created #7811

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 17, 2024

What

Without this the blueprint goes to the old view before the new view gets set up.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🪳 bug Something isn't working notebook Jupyter notebooks etc labels Oct 17, 2024
@jleibs jleibs marked this pull request as ready for review October 17, 2024 14:24
@jleibs jleibs added this to the Next patch release milestone Oct 17, 2024
@jleibs jleibs changed the title Don't send blueprint to notebook until after changing the stream handle [bugfix] Make sure blueprint gets sent to the notebook view being created Oct 17, 2024
@jleibs jleibs merged commit ca18924 into main Oct 17, 2024
35 of 40 checks passed
@jleibs jleibs deleted the jleibs/fix_notebook_send_order branch October 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog notebook Jupyter notebooks etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants