Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebGL renderer failing to display video #7381

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 9, 2024

What

This is obviously a brittle hack, but allows us to move on without having to wait on a wgpu release containing gfx-rs/wgpu#6170 :)

Tested using pixi run rerun-web /Users/andreas/Desktop/sample\ videos/Big_Buck_Bunny_720_10s_30MB_av1.mp4 (insert video of your choice) and then running http://localhost:9090/?url=ws%3A%2F%2Flocalhost%3A9877&renderer=webgl in Chrome (on Mac. shouldn't matter much as long as the browser has webcodec support and draws video)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Sep 9, 2024
@Wumpf Wumpf changed the title Fix WebGL renderer not failing to display video Fix WebGL renderer failing to display video Sep 9, 2024
Copy link
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We love more hacks! LGTM:

image

@Wumpf Wumpf merged commit 0bea9e7 into main Sep 10, 2024
35 of 38 checks passed
@Wumpf Wumpf deleted the andreas/workaround-webgl-video-issues branch September 10, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix web VideoDecoder on Chromium/WebGL
2 participants