Fix WebGL renderer failing to display video #7381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
VideoDecoder
on Chromium/WebGL #7328This is obviously a brittle hack, but allows us to move on without having to wait on a wgpu release containing gfx-rs/wgpu#6170 :)
Tested using
pixi run rerun-web /Users/andreas/Desktop/sample\ videos/Big_Buck_Bunny_720_10s_30MB_av1.mp4
(insert video of your choice) and then runninghttp://localhost:9090/?url=ws%3A%2F%2Flocalhost%3A9877&renderer=webgl
in Chrome (on Mac. shouldn't matter much as long as the browser has webcodec support and draws video)Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.