Add VideoFrame to ExternalImageSource enum
#6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what the policy is for unstable APIs, but this requires |
6 tasks
|
I thought |
|
It was removed, but this PR doesn't invalidate that one, because |
6 tasks
Wumpf
added a commit
to rerun-io/rerun
that referenced
this pull request
Sep 10, 2024
### What * Fixes #7328 This is obviously a brittle hack, but allows us to move on without having to wait on a wgpu release containing gfx-rs/wgpu#6170 :) Tested using `pixi run rerun-web /Users/andreas/Desktop/sample\ videos/Big_Buck_Bunny_720_10s_30MB_av1.mp4` (insert video of your choice) and then running `http://localhost:9090/?url=ws%3A%2F%2Flocalhost%3A9877&renderer=webgl` in Chrome (on Mac. shouldn't matter much as long as the browser has webcodec support and draws video) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7381?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7381?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7381) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
ExternalImageSource::VideoFrame#6167Description
Adds missing
VideoFrametype as a possible external image source.The enum variant is gated behind
cfg(web_sys_unstable_apis), asweb_sys::VideoFrameis unavailable without it.Testing
Tested manually by using it in place of this hack: https://github.com/rerun-io/rerun/pull/7261/files#diff-213f45076b49c7bbe3d7a1f0c7383b3b9e0edb4c02c21bab32709573155a2e63R403-R414
It would be nice to have a Wasm-only example that renders a media stream using
VideoDecoder, but I'm not sure how adding such an example would work.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.