Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test all known HybridResults issues from 0.18 #7297

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 28, 2024

This fixes all known bugs/regressions introduced in the visualizer-query layer (aka HybridResults) in 0.18, and adds related checklists for futureproof-ness.

As always, this is "just" a matter of carefully overriding row indices when merging data from multiple sources with different priorities.

TODO:

  • check_latest_at_partial_updates passing
  • check_latest_at_partial_updates comparison with 0.17
  • check_range_partial_updates passing
  • check_range_partial_updates comparison with 0.17
    0.17 was in the wrong on this one!
  • check_static_override passing
  • check_plot_overrides passing
  • check_overrides_2d passing
  • all standard examples behaving sanely
  • cargo t --all-features --all
  • plot dashboard not doing anything weird

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🔨 testing testing and benchmarks 🦟 regression A thing that used to work in an earlier release include in changelog labels Aug 28, 2024
@teh-cmc teh-cmc force-pushed the cmc/hybrid_results_shenaniganeries branch from 4fa22e6 to 099edf0 Compare August 28, 2024 10:30
@teh-cmc teh-cmc marked this pull request as ready for review August 28, 2024 10:48
@teh-cmc teh-cmc merged commit 9aea808 into main Aug 28, 2024
36 of 48 checks passed
@teh-cmc teh-cmc deleted the cmc/hybrid_results_shenaniganeries branch August 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🦟 regression A thing that used to work in an earlier release 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intra-timestamps join broken for spatial views on 0.18
2 participants