Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intra-timestamps join broken for spatial views on 0.18 #7227

Closed
teh-cmc opened this issue Aug 18, 2024 · 3 comments · Fixed by #7297
Closed

Intra-timestamps join broken for spatial views on 0.18 #7227

teh-cmc opened this issue Aug 18, 2024 · 3 comments · Fixed by #7297
Assignees
Labels
🪳 bug Something isn't working 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Milestone

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Aug 18, 2024

See e.g. this:

import rerun as rr

rr.init("rerun_example_points3d", spawn=True)

rr.set_time_sequence("frame", 42)
rr.log("points", rr.Points3D([[0, 0, 0], [1, 1, 1]], radii=-5, colors=[255, 0, 0]))
rr.log(
    "points", rr.Points3D([[10, 10, 10], [11, 11, 11]], radii=-5, colors=[0, 255, 0])
)

On 0.17 this yields what you'd expect:
image

On 0.18 this will fail though:
image

The is a regression following #7199, which fixes that static/override case but breaks the common case.

@teh-cmc teh-cmc added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself 🦟 regression A thing that used to work in an earlier release labels Aug 18, 2024
@Wumpf
Copy link
Member

Wumpf commented Aug 18, 2024

urgh. I feared something like that would happen but we assumed all is well when we tested overriding static data :(

@nikolausWest nikolausWest added this to the 0.18.1 milestone Aug 18, 2024
@teh-cmc teh-cmc self-assigned this Aug 19, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 20, 2024

Ha dang, this might be worse than I thought -- I think this breaks log_components workflow completely.

I'll add dedicated checklists so this doesn't surprise us again.

TODO:

  • checklist for intra range
  • checklist for log_components (both primary and secondary changes)
  • checklist for static overrides

@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 28, 2024

Found a lot more issues of that nature, many of which were not introduced by #7199.

I'll have a PR ready for all known visualizer-query bugs, at some point.

The first problem is that the basic overrides test suite doesn't even run on 0.18.0 it turns out:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants