Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a minimum version of pillow in rerun_py/pyproject.toml #6327

Merged
merged 4 commits into from
May 15, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 15, 2024

What

A user reported that

rr.log("foo", rr.Image(img).compress(jpeg_quality=95))

caused this warning:

RerunWarning: Image compression: TypeError(open() got an unexpected keyword argument 'formats')

I suspect this line:

img_data = PILImage.open(buffer, formats=formats)

Which indicate a version mismatch of pillow.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🪳 bug Something isn't working 🐍 Python API Python logging API dependencies concerning crates, pip packages etc include in changelog labels May 15, 2024
@emilk emilk added this to the 0.16 milestone May 15, 2024
Copy link

Deployed docs

Commit Link
3c99f1f https://landing-dzjnoa4ky-rerun.vercel.app/docs

@Wumpf
Copy link
Member

Wumpf commented May 15, 2024

lint failure got fixed on main

@Wumpf Wumpf merged commit bf84f3c into main May 15, 2024
36 of 39 checks passed
@Wumpf Wumpf deleted the emilk/pillow-version branch May 15, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working dependencies concerning crates, pip packages etc include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants