Skip to content

Commit

Permalink
Set a minimum version of pillow in rerun_py/pyproject.toml (#6327)
Browse files Browse the repository at this point in the history
### What
A user reported that

``` py
rr.log("foo", rr.Image(img).compress(jpeg_quality=95))
```

caused this warning:

> RerunWarning: Image compression: TypeError(open() got an unexpected
keyword argument 'formats')

I suspect this line:


https://github.com/rerun-io/rerun/blob/3805781ee53dec571bfef0b0c44d95e61fc690ca/rerun_py/rerun_sdk/rerun/_image.py#L203

Which indicate a version mismatch of pillow.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [ ] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6327?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6327?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6327)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
  • Loading branch information
emilk authored May 15, 2024
1 parent 77e15a2 commit bf84f3c
Show file tree
Hide file tree
Showing 3 changed files with 2,183 additions and 2,173 deletions.
8 changes: 1 addition & 7 deletions examples/python/raw_mesh/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,7 @@
name = "raw_mesh"
version = "0.1.0"
readme = "README.md"
dependencies = [
"numpy",
"requests>=2.31,<3",
"rerun-sdk",
"trimesh==3.15.2",
"pillow",
]
dependencies = ["numpy", "requests>=2.31,<3", "rerun-sdk", "trimesh==3.15.2"]

[project.scripts]
raw_mesh = "raw_mesh.__main__:main"
Expand Down
Loading

0 comments on commit bf84f3c

Please sign in to comment.