-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunset MeshProperties
, introduce TriangleIndices
and friends
#6169
Conversation
Deployed docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have absolutely no idea why this was the only one with nullability baked in oO.
Probably an old hack if I had to guess...
This still breaks join semantics. You've just made it so that breaking join semantics is now allowed and the knowledge of how to join is implicitly deferred to the visualizer. I still think we should consider introducing a "non-joinable" attribute as an annotation for components where the conventional join is known not to work to help us out with things like instance-selection. |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/8893612099 |
Co-authored-by: Emil Ernerfeldt <[email protected]>
MeshProperties
, introduce UVector3D
and friendsMeshProperties
, introduce TriangleIndices
and friends
MeshProperties
was a hack that was required because of the old join semantics.We can now make
Mesh3D.triangle_indices
what we always intended: aVec<UVec3>
.(This won't work in the web viewer generated by this PR since it breaks the Mesh3D ABI.)
MeshProperties
#5402Migrations
C++
Python
Rust
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.