New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of awkward `MeshProperties` #5402

Closed

teh-cmc opened this issue Mar 5, 2024 · 0 comments · Fixed by #6169

Assignees

Labels

🔩 data model 🪵 Log & send APIs

Member

teh-cmc commented Mar 5, 2024

This only existed so Mesh could fit into the instance-key-based data model.

Now that visualizers have more agency wrt the join semantics, this can be put at the root of the archetype like anything else.

The text was updated successfully, but these errors were encountered:

teh-cmc added 🔩 data model 🪵 Log & send APIs labels

teh-cmc self-assigned this

teh-cmc mentioned this issue

Sunset MeshProperties, introduce TriangleIndices and friends #6169

Merged

5 tasks

teh-cmc closed this as completed in #6169

teh-cmc added a commit that referenced this issue


          Sunset MeshProperties, introduce UVector3D and friends (#6169)

2b9f4ba

`MeshProperties` was a hack that was required because of the old join
semantics.
We can now make `Mesh3D.triangle_indices` what we always intended: a
`Vec<UVec3>`.

(This won't work in the web viewer generated by this PR since it breaks
the Mesh3D ABI.)

- Fixes #5402 


![image](https://github.com/rerun-io/rerun/assets/2910679/e8046702-252a-4240-9dcf-cd1d2bcfc98a)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment