-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI for static components #6101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@abey79: question on this we never talked about. How do we report the opposite case where someone logged data as timeful first, and then logged as static (in which case I believe we are supposed to ignore the static call)? |
static data always take priority, irrelevant of what got logged first. |
Yeah. That piece of data would be displayed as a regular timeful thing, and as soon as the static log is ingested by the viewer, its back to the error/warning display of this PR. |
Ok, great, well that keeps things simpler then |
What
This PR updates the UI to better display static components, including:
<static>
for static components. This appears both in the selection panel and in the hover tooltips.Note: the included release checklist is nice to try the error/warning cases.
Screenshots
static + timeful error:
multi-static warning:
selection panel:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.