-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update UI for static components (#6101)
### What This PR updates the UI to better display static components, including: - Components logged as static now have a different icon. - Components logged as static do not have any event displayed in the timeline (see below for possible follow-up work). - The "timeless" gutter in the timeline is gone. - The hover tooltip in the streams for static component now displays their content (timeful components have their content displayed on the corresponding event in the timeline). - All components now have a "logged time" displayed along their data (showing the actually logging time that was taken into consideration by the current LatestAt query). It shows `<static>` for static components. This appears both in the selection panel and in the hover tooltips. - In addition, data consistency information is displayed for static component (both tooltip and selection panel): - Warning (yellow) if multiple static logs were recorded (the data of previous logging event is overwritten and not recoverable from the datastore). - Error (red) if the static component has timeful stuff logged as well (albeit that data is not loss, it's not queryable and extremely likely an indication of user error). Note: the included release checklist is nice to try the error/warning cases. - Fixes #6074 - Possible follow-up #6102 ### Screenshots static + timeful error: <img width="368" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/98c7f1c8-8cf0-4604-95b8-ab7291bd1c20"> multi-static warning: <img width="334" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/4d8e7612-bb3e-4295-bbd1-f9ba0554ac2a"> selection panel: <img width="295" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/a63178ed-adcc-434f-8425-3b22ba88d003"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6101?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6101?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6101) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information
Showing
17 changed files
with
235 additions
and
80 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.