Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various links in rust, python and toml files #5986

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 16, 2024

What

Code files are now included in link checking.

Some issues encountered:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation include in changelog 🚢 CI labels Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

Deployed docs

Commit Link
22e1992 https://landing-p5v1tt8b0-rerun.vercel.app/docs

@Wumpf Wumpf force-pushed the andreas/more-link-check-fixing branch from d87268b to 21f204c Compare April 16, 2024 09:28
@Wumpf Wumpf marked this pull request as ready for review April 16, 2024 09:54
@Wumpf
Copy link
Member Author

Wumpf commented Apr 16, 2024

@jprochazk
Copy link
Member

Does it have a way to report which links it checked so we can be sure that it checks what linkinator missed?

@Wumpf
Copy link
Member Author

Wumpf commented Apr 16, 2024

Does it have a way to report which links it checked so we can be sure that it checks what linkinator missed?

yes, I documented that in lychee.toml: you pass in --dump-link and it tells you.
Or do you mean we should have something on ci as well as an artifact?

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jprochazk
Copy link
Member

jprochazk commented Apr 16, 2024

Yes, I meant on CI. Linkinator would always report the full list of links it checked, would be nice to have that instead of just the number of links, as long as it's not too much work to add here.

@Wumpf
Copy link
Member Author

Wumpf commented Apr 16, 2024

I'll have a look!

@Wumpf
Copy link
Member Author

Wumpf commented Apr 16, 2024

@Wumpf Wumpf merged commit 44c4d3f into main Apr 16, 2024
35 of 36 checks passed
@Wumpf Wumpf deleted the andreas/more-link-check-fixing branch April 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better link checker on CI (linkinator and lychee misses important things)
3 participants