Better link checker on CI (linkinator and lychee misses important things)
#5925
Assignees
Labels
Comments
emilk
changed the title
linkinator misses important things)
|
|
The new link checker didn't catch the broken link to https://github.com/rerun-io/rerun/blob/latest/examples/rust/custom_data/src/main.rs which was part of the litmus test of this issue |
emilk
changed the title
linkinator misses important things)linkinator and lychee misses important things)
5 tasks
Wumpf
added a commit
that referenced
this issue
Apr 16, 2024
### What Code files are now included in link checking. * Fixes #5925 Some issues encountered: * globs don't respect exclude_files which makes working with this locally harder lycheeverse/lychee#1405 * can't specify extensions / correct files aren't picked up automatically lycheeverse/lychee#410 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5986?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5986?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5986) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Another example:
https://docs.rs/rerun/latest/rerun/trait.AsComponents.html links to https://github.com/rerun-io/rerun/blob/latest/examples/rust/custom_data/src/main.rs which is 404 - I've intentionally not fixed this link yet so we can check that the fixed link checker catches it
This makes me worried that we have a lot of broken links.
We need to either fix
linkinator, or switch to a better tool.The text was updated successfully, but these errors were encountered: