Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web viewer crash on invalid url parameter #5631

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Fix web viewer crash on invalid url parameter #5631

merged 1 commit into from
Mar 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 21, 2024 •
edited
Loading

What

Gracefully handle broken or missing urls for websocket connections.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser include in changelog labels Mar 21, 2024
@github-actions GitHub Actions
Copy link

Size changes

Name main 5631/merge Change
rrt-star.rrd 9.13 MiB 2.01 MiB -77.98%

emilk
emilk approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Wumpf Wumpf merged commit 980099f into main Mar 22, 2024
37 of 38 checks passed
@Wumpf Wumpf deleted the andreas/fix-crash-on-invalid-url branch March 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Viewer ?url parameter crashes when no URL is provided
2 participants
@Wumpf @emilk