Web Viewer ?url parameter crashes when no URL is provided
#5405
Assignees
Labels
🪳 bug
Something isn't working
🏎️ Quick Issue
Can be fixed in a few hours or less
🕸️ web
regarding running the viewer in a browser
Milestone
Comments
kovar
added
👀 needs triage
Wumpf
added
🕸️ web
5 tasks
Wumpf
added a commit
that referenced
this issue
Mar 22, 2024
### What Gracefully handle broken or missing urls for websocket connections. * Fixes #5405 <img width="429" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/b8fab58c-e76d-4744-bfcc-935eeca41737"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5631/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5631/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5631/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5631) - [Docs preview](https://rerun.io/preview/077d99a586094d3ad1c6f7d240426d6a29e3d8db/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/077d99a586094d3ad1c6f7d240426d6a29e3d8db/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Minor thing. If no URL is provided for the https://app.rerun.io/?url= functionality, Rerun crashes.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Inform the user that no/faulty URL was provided.
Screenshots
Backtrace
intentionally left blank
Desktop (please complete the following information):
Rerun version
The one that is currently on the web (I suspect v0.14.1)
Additional context
#4527
Also the link to bug report shown on the page could link to the bug report template, instead it links to generic new issue. Thanks for all your work! 👏
The text was updated successfully, but these errors were encountered: