-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically expand and scroll the streams tree when focusing on an item #5494
Conversation
There seem to be issues with the visibility check. Example here where the time panel won't scroll even though I cannot see the entity: 24-03-14_09.04.15.patched.mp4(Also I cannot help but notice that there's no selection highlight in the time panel -- wasn't that implemented? I lost track of all the improvements!) |
@teh-cmc yeah sorry, this should be marked as draft. There is a bug going on here that I haven't been able to track so far. Edit: fixed. And yeah, "sister-selection" is still on the todo list. It will make that focus feature much nicer. |
# Conflicts: # Cargo.lock # Cargo.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice
# Conflicts: # Cargo.toml
What
This PR adds support for expanding and scrolling to the focus item in the Streams view. It also adds expanding/scrolling the Blueprint tree when focusing on a component.
ScrollArea
bugs: leaking scroll target and broken animation to target offset emilk/egui#4174TODO:
focus_scroll_works.mp4
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io