Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-clicking an entity/instance/component anywhere should put it and its ancestors into focus _everywhere_ #5232

Closed
teh-cmc opened this issue Feb 20, 2024 · 1 comment · Fixed by #5494
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 20, 2024

Where "everywhere" includes but isn't limited too:

  • all mentions in the blueprint panel
  • all mentions in the timeline panel
  • all mentions in the selection panel
  • all appearances in all space views

Today, only the 3D view respects that (e.g. if you double-click an entity in the timeline panel, all 3D views that show that entity will focus the camera on it).

In space views, "putting into focus" means panning/zooming the camera towards the double-clicked entity.
In other panels, it means auto-scrolling the panel to get to that entity (what happens when the entity exists multiple times in that panel remains to be seen etc).

cc @abey79

@teh-cmc teh-cmc added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use labels Feb 20, 2024
@abey79 abey79 self-assigned this Feb 27, 2024
@abey79 abey79 added the 🏎️ Quick Issue Can be fixed in a few hours or less label Mar 12, 2024
abey79 added a commit that referenced this issue Mar 18, 2024
…item (#5494)

### What

- Follow up to #5482
- Fixes #5232 


This PR adds support for expanding and scrolling to the focus item in
the Streams view. It also adds expanding/scrolling the Blueprint tree
when focusing on a component.

- Blocked on emilk/egui#4174

TODO:
- [x] update egui commit once ☝🏻  is merged


https://github.com/rerun-io/rerun/assets/49431240/55c2959f-bb9b-4f67-b20b-06ba82175d71


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5494/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5494/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5494/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5494)
- [Docs
preview](https://rerun.io/preview/e879778c92dd2e50eb05bc6fdefee9ac79b93872/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/e879778c92dd2e50eb05bc6fdefee9ac79b93872/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants