Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use Python 3.11 in pixi #5365

Merged
merged 11 commits into from
Mar 1, 2024
Merged

Always use Python 3.11 in pixi #5365

merged 11 commits into from
Mar 1, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 1, 2024

What

We should all use the same Pyhthon version for linting, otherwise we will get different results. For instance, I get 60 errors running pixi run lint-py-mypy on main

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Mar 1, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly strong reject on my part. As noted on slack, this can cause lots of issues. For example: this caps mypy to a version that supports 3.8, which might be old, and less stringent than more recent mypy version.

My general rule of thumb:

  • lint/format/whatnot with the most recent supported version
  • run tests on all supported versions

@emilk emilk changed the title Always use Python 3.8 in pixi Always use Python 3.12 in pixi Mar 1, 2024
@emilk
Copy link
Member Author

emilk commented Mar 1, 2024

Ok, I've changed it to always run Python 3.12 in pixi instead, and to run our nox "test on all python versions" on CI

@abey79 abey79 self-requested a review March 1, 2024 09:43
@emilk
Copy link
Member Author

emilk commented Mar 1, 2024

This fixes pixi run lint-py-mypy for me, which used to return 60 errors before

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.github/workflows/contrib_rerun_py.yml Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Mar 1, 2024

Trying to get pixi run pip install -r examples/python/requirements.txt to work…

@emilk emilk changed the title Always use Python 3.12 in pixi Always use Python 3.11 in pixi Mar 1, 2024
@emilk
Copy link
Member Author

emilk commented Mar 1, 2024

Went down to 3.11 to get CI green, and now pixi run lint-py-mypy fails again oh it works again

@emilk emilk merged commit 020eab4 into main Mar 1, 2024
35 checks passed
@emilk emilk deleted the emilk/python-3.8 branch March 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants