Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for perspective cameras #5238

Merged
merged 12 commits into from
Feb 22, 2024
Merged

Add helpers for perspective cameras #5238

merged 12 commits into from
Feb 22, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 20, 2024

All SDKs + examples etc

rr.log("world/cam", rr.Pinhole(fov_y=0.7853982, aspect_ratio=1.7777778, camera_xyz=rr.ViewCoordinates.RUB))
rr.log("world/points", rr.Points3D([(0.0, 0.0, -0.5), (0.1, 0.1, -0.5), (-0.1, -0.1, -0.5)]))

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API 🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Feb 20, 2024
@teh-cmc teh-cmc marked this pull request as draft February 20, 2024 14:34
@teh-cmc teh-cmc force-pushed the cmc/perspective_logging branch 2 times, most recently from 5735daf to 5307e8f Compare February 21, 2024 14:41
@teh-cmc teh-cmc marked this pull request as ready for review February 21, 2024 14:41
@teh-cmc teh-cmc force-pushed the cmc/perspective_logging branch from 5307e8f to 5ab5552 Compare February 21, 2024 14:43
docs/code-examples/all/pinhole_perspective.rs Outdated Show resolved Hide resolved
crates/re_types/src/archetypes/pinhole_ext.rs Outdated Show resolved Hide resolved
docs/code-examples/all/pinhole_perspective.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/pinhole_ext.cpp Outdated Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/archetypes/pinhole_ext.py Outdated Show resolved Hide resolved
@teh-cmc teh-cmc merged commit e2826e1 into main Feb 22, 2024
41 of 43 checks passed
@teh-cmc teh-cmc deleted the cmc/perspective_logging branch February 22, 2024 08:28
teh-cmc added a commit that referenced this pull request Feb 22, 2024
All SDKs + examples etc

```python
rr.log("world/cam", rr.Pinhole(fov_y=0.7853982, aspect_ratio=1.7777778, camera_xyz=rr.ViewCoordinates.RUB))
rr.log("world/points", rr.Points3D([(0.0, 0.0, -0.5), (0.1, 0.1, -0.5), (-0.1, -0.1, -0.5)]))
```

<picture>
<img
src="https://static.rerun.io/pinhole_perspective/d0bd02a0cf354a5c8eafb79a84fe8674335cab98/full.png"
alt="">
<source media="(max-width: 480px)"
srcset="https://static.rerun.io/pinhole_perspective/d0bd02a0cf354a5c8eafb79a84fe8674335cab98/480w.png">
<source media="(max-width: 768px)"
srcset="https://static.rerun.io/pinhole_perspective/d0bd02a0cf354a5c8eafb79a84fe8674335cab98/768w.png">
<source media="(max-width: 1024px)"
srcset="https://static.rerun.io/pinhole_perspective/d0bd02a0cf354a5c8eafb79a84fe8674335cab98/1024w.png">
<source media="(max-width: 1200px)"
srcset="https://static.rerun.io/pinhole_perspective/d0bd02a0cf354a5c8eafb79a84fe8674335cab98/1200w.png">
</picture>

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants