dealing with chatgpt's betrayal

docs/code-examples/all/pinhole_perspective.rs

@@ -3,7 +3,7 @@
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     let rec = rerun::RecordingStreamBuilder::new("rerun_example_pinhole_perspective").spawn()?;
 
-    let fov = std::f32::consts::FRAC_PI_4;
+    let fov = 0.7853982;
     let aspect_ratio = 1.7777778;
     rec.log(
         "world/cam",

rerun_cpp/src/rerun/archetypes/pinhole_ext.cpp

@@ -35,7 +35,7 @@ namespace rerun {
         /// Assumes the principal point to be in the middle of the sensor.
         static Pinhole from_fov_and_aspect_ratio(float fov_y, float aspect_ratio) {
             const float EPSILON = std::numeric_limits<float>::epsilon();
-            const float focal_length_y = 0.5f / std::max(fov_y * 0.5f, EPSILON);
+            const float focal_length_y = 0.5f / std::tan(std::max(fov_y * 0.5f, EPSILON));
             return from_focal_length_and_resolution(
                 {focal_length_y, focal_length_y},
                 {aspect_ratio, 1.0}

rerun_py/rerun_sdk/rerun/archetypes/pinhole_ext.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import math
 from typing import Any, cast
 
 import numpy.typing as npt
@@ -84,6 +85,7 @@ def __init__(
             Vertical field of view.
         aspect_ratio
             Aspect ratio.
+
         """
 
         with catch_and_log_exceptions(context=self.__class__.__name__):
@@ -96,7 +98,7 @@ def __init__(
             if image_from_camera is None:
                 if fov_y is not None and aspect_ratio is not None:
                     EPSILON = 1.19209e-07
-                    focal_length = focal_length = 0.5 / max(fov_y * 0.5, EPSILON)
+                    focal_length = focal_length = 0.5 / math.tan(max(fov_y * 0.5, EPSILON))
                     resolution = [aspect_ratio, 1.0]
 
                 if resolution is not None: