Remove egui_plot as dependency from re_sdk
#5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🧑💻 dev experience
emilk
changed the title
egui_plot as dependency from rerun-sdkegui_plot as dependency from re_sdk
This was referenced Feb 7, 2024
Closed
teh-cmc
force-pushed
the
emilk/trim-rerun-deps
branch
from
33b58c3 to
a519074
Compare
teh-cmc
reviewed
Feb 7, 2024
| @@ -282,3 +281,12 @@ impl SpaceViewClass for BarChartSpaceView { | |||
| Ok(()) | |||
| } | |||
| } | |||
|
|
|||
| fn to_egui_lot_corner(value: LegendCorner) -> egui_plot::Corner { | |||
There was a problem hiding this comment.
I would have fixed this quickly, but someone has force-pushed to my branch :P
teh-cmc
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #4788
We need to start tracking the number of dependencies and/or compile-time of
re_sdk: #5101.@v-morlock pointed out in https://github.com/rerun-io/rerun/issues/5095we accidentally pull in all of
egui🤦This PR fixes that.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io