Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce marker size component #5057

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 6, 2024

What

Allows to configure size again for points wiht the new PointSeries archetype.

Makes size of plot line and marker independent which is kinda neat :)
image
(Color is not independent, we'll want to solve this differently in the future in accordance to the model we're going with, but up for discussion obviously)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 6, 2024
@teh-cmc teh-cmc self-requested a review February 6, 2024 10:50
@teh-cmc
Copy link
Member

teh-cmc commented Feb 6, 2024

  • Checked on web ✅

@teh-cmc teh-cmc merged commit 91a41b4 into main Feb 6, 2024
41 of 43 checks passed
@teh-cmc teh-cmc deleted the andreas/marker-size-component branch February 6, 2024 11:41
teh-cmc added a commit that referenced this pull request Feb 6, 2024
…ad (#5042)

### What

Also fixes missing serialization of `StrokeWidth` & `MarkerSize`


![image](https://github.com/rerun-io/rerun/assets/1220815/44a118d4-5dc7-4c6d-a79b-29f83ac7eb77)


blocked by a few things:
* [x] text labels should go on SeriesLine/SeriesPlot  #5043
* [x] SeriesPoint doesn't have a `MarkerSize` component yet #5057
* [x] Need to fix heuristic for only having Scalar -> Line #5050

---------

Co-authored-by: Clement Rey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants