Update all examples that use TimeSeriesScalar to use Scalar instead
#5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📖 documentation
Size changes
|
4 tasks
Wumpf
added a commit
that referenced
this pull request
Feb 6, 2024
### What * Needed by #5042 Last commit also removes the now fairly useless Text component on Scalar (until we support labeling points). This makes it a bit less compatible with the legacy TimeSeriesScalar, but that in and on itself shouldn't be much of a problem. <img width="538" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/5950303f-cad3-4302-acb8-55e3aba3778a"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5043/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5043/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5043/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/5043) - [Docs preview](https://rerun.io/preview/5da9bca98bbf24bf8671388a5190eef75e1e6019/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/5da9bca98bbf24bf8671388a5190eef75e1e6019/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf
force-pushed
the
andreas/update-timeseries-examples
branch
from
151f984 to
c0a0026
Compare
Wumpf
force-pushed
the
andreas/update-timeseries-examples
branch
2 times, most recently
from
274acc3 to
fec976e
Compare
teh-cmc
pushed a commit
that referenced
this pull request
Feb 6, 2024
### What * Needed for #5042 Allows to configure size again for points wiht the new PointSeries archetype. Makes size of plot line and marker independent which is kinda neat :) <img width="952" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/cd24a449-e839-4db2-abf5-782e8dcf96af"> (Color is *not* independent, we'll want to solve this differently in the future in accordance to the model we're going with, but up for discussion obviously)
…ey don't right now!)
teh-cmc
force-pushed
the
andreas/update-timeseries-examples
branch
from
fec976e to
d876540
Compare
teh-cmc
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Dang that's like the first time one of our example makes real use of the per-component latest-at semantics 😱
|
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Also fixes missing serialization of
StrokeWidth&MarkerSizeblocked by a few things:
MarkerSizecomponent yet Introduce marker size component #5057Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io