Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lagging time cursor when panning a time series plot #4972

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 30, 2024

Also removes frame-delay when dragging said time cursor (see commits).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Jan 30, 2024
@Wumpf Wumpf self-requested a review January 30, 2024 15:07
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice! so tight! thought this was a much harder problem

@emilk emilk merged commit 19f5382 into main Jan 30, 2024
40 checks passed
@emilk emilk deleted the emilk/fix-plot-frame-delay branch January 30, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time cursor lag in time series view
2 participants