Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time cursor lag in time series view #4564

Closed
kpreid opened this issue Dec 16, 2023 · 0 comments · Fixed by #4972
Closed

Time cursor lag in time series view #4564

kpreid opened this issue Dec 16, 2023 · 0 comments · Fixed by #4972
Assignees
@emilk
Labels
😤 annoying Something in the UI / SDK is annoying to use ui concerns graphical user interface
Milestone
0.13

Comments

@kpreid
Copy link
Collaborator

kpreid commented Dec 16, 2023

Describe the annoyance
I was exploring the time series visualization capabilities, and I noticed that the cursor marking the current time was lagging behind the graphs when dragged. This does not significantly impact usage, but it's a sign that something could be improved in the update/invalidation/repaint logic to make the visualization more stable and efficiently computed.

To Reproduce
Steps to reproduce the behavior:

  1. Open a time series view.
  2. Click and drag, or rather, shake vigorously.
  3. Watch where the graph intersects the cursor.

Screenshots

The following video capture is slowed down 10× for visibility:

shake-slow.mp4

Desktop (please complete the following information):

  • OS: macOS Monterey 12.7.1
  • rerun-cli version 0.11.0
@kpreid kpreid added 👀 needs triage This issue needs to be triaged by the Rerun team 😤 annoying Something in the UI / SDK is annoying to use labels Dec 16, 2023
@abey79 abey79 added ui concerns graphical user interface 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 18, 2023
@emilk emilk changed the title Cursor lag in time series view Time cursor lag in time series view Dec 19, 2023
@nikolausWest nikolausWest added this to the 0.13 milestone Jan 15, 2024
@Wumpf Wumpf removed the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 30, 2024
@emilk emilk self-assigned this Jan 30, 2024
@emilk emilk mentioned this issue Jan 30, 2024
Merged
4 tasks
emilk added a commit that referenced this issue Jan 30, 2024
@emilk
Fix lagging time cursor when panning a time series plot (#4972)
19f5382 
* Closes [#4564](#4564)

Also removes frame-delay when dragging said time cursor (see commits).

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4972/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4972/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4972/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4972)
- [Docs
preview](https://rerun.io/preview/5332e5019ba61e4deb9b61478005487293d1c4ab/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/5332e5019ba61e4deb9b61478005487293d1c4ab/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
😤 annoying Something in the UI / SDK is annoying to use ui concerns graphical user interface
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Fix lagging time cursor when panning a time series plot rerun-io/rerun
5 participants
@kpreid @emilk @Wumpf @nikolausWest @abey79