Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes on spatial transforms & spatial topology #4908

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 25, 2024

What

As discussed on Slack, noted down what we decided on spatial transforms. Extended it a bit from there

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 25, 2024
Comment on lines +33 to +34
## Null transforms
Null transforms are handled like identity transforms, the same as not logging a transform at all.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we might want to introduce is a union-arm like: Transform3D::Unknown which acts as a 3D transform topologically speaking, but will return some kind of "Temporarily disconnected" result during runtime evaluation and prevent the reprojection from taking place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm but we shouldn't make this affect our visualizability calculation I think since as you say the "unreachability" is entirely temporary

@Wumpf Wumpf merged commit 593fa49 into main Jan 26, 2024
6 checks passed
@Wumpf Wumpf deleted the andreas/notes-on-spatial-transforms branch January 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formalize specification/documentation of how transforms interact with heuristics and queries
2 participants