Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize specification/documentation of how transforms interact with heuristics and queries #4655

Closed
jleibs opened this issue Jan 3, 2024 · 2 comments · Fixed by #4908
Closed
Labels
🔩 data model enhancement New feature or request

Comments

@jleibs
Copy link
Member

jleibs commented Jan 3, 2024

There are several open questions at the moment regarding where transforms fit into the heuristic system.

  • Do they only impact "Spatial" views or can they be used to split content in different kinds of views.
  • Is there a mechanism to "query" entities up to the next transform?
  • Is there actually a difference between a "DisconnectedSpace" and a Null "SpatialTransform?"
  • Can a pinhole transform be converted to a rigid transform or does it create a permanent topological disconnect between 2d and 3d spaces.
  • Can 3D content be added to a 2D space without a transform?

This would improve clarity for users in issues like:

@Wumpf
Copy link
Member

Wumpf commented Jan 25, 2024

We got answers for all of these by now and most of them even coded up:

  • Do they only impact "Spatial" views or can they be used to split content in different kinds of views.
    • only impact spatial views. SpaceInfo should go away
  • Is there a mechanism to "query" entities up to the next transform?
    • transforms propagation is part of general property propagation
  • Is there actually a difference between a "DisconnectedSpace" and a Null "SpatialTransform?"
    • Yes. A disconnected space changes the spacial topology. A null spatial transform is handled as identity
  • Can a pinhole transform be converted to a rigid transform or does it create a permanent topological disconnect between 2d and 3d spaces.
    • no. It's a permanent topological disconnect
  • Can 3D content be added to a 2D space without a transform?
    • no

@jleibs plz check over these and close if we're on the same page. If not then this ticket is clearly not done 😄

@jleibs
Copy link
Member Author

jleibs commented Jan 25, 2024

Agree we're on the same page. Would be great to capture this somewhere durable. Almost like we need a spatial-transform architecture markdown doc. (Which is where we would also add future notes on semantics for things like time-varying transforms #1522)

Wumpf added a commit that referenced this issue Jan 26, 2024
### What

* Fixes #4655

As discussed on Slack, noted down what we decided on spatial transforms.
Extended it a bit from there

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)
<!--DOCS-PREVIEW-->
- [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants