Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for compressing mono images by respecting mode to determine depth #4847

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Fix support for compressing mono images by respecting mode to determine depth #4847

merged 3 commits into from
Jan 19, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jan 17, 2024 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 🐍 Python API Python logging API 🪳 bug Something isn't working include in changelog labels Jan 17, 2024
@jleibs jleibs marked this pull request as ready for review January 17, 2024 19:40
@jleibs
Copy link
Member Author

jleibs commented Jan 17, 2024

@SeaOtocinclus thanks for reporting -- this should fix the issue

@Wumpf Wumpf self-requested a review January 19, 2024 08:23
Wumpf
Wumpf approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great work on enhancing the existing tests and adding a new one!

@Wumpf Wumpf merged commit b6a0ea1 into main Jan 19, 2024
41 of 45 checks passed
@Wumpf Wumpf deleted the jleibs/compress_mono_jpeg branch January 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image.compress results in incorrect shape when used on mono images
2 participants
@jleibs @Wumpf