Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image.compress results in incorrect shape when used on mono images #4846

Closed
jleibs opened this issue Jan 17, 2024 · 0 comments · Fixed by #4847
Closed

Image.compress results in incorrect shape when used on mono images #4846

jleibs opened this issue Jan 17, 2024 · 0 comments · Fixed by #4847
Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Milestone
0.13

Comments

@jleibs
Copy link
Member

jleibs commented Jan 17, 2024

Repo:

import numpy as np
import rerun as rr

rr.init("rerun_example_image_simple", spawn=True)
image = np.zeros((200, 300), dtype=np.uint8)
rr.log("image", rr.Image(image).compress(jpeg_quality=76))

When viewing image in the viewer you just get the message:
image
@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 🐍 Python API Python logging API and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 17, 2024
@jleibs jleibs added this to the 0.13 milestone Jan 17, 2024
@jleibs jleibs mentioned this issue Jan 17, 2024
Merged
4 tasks
Wumpf pushed a commit that referenced this issue Jan 19, 2024
@jleibs
Fix support for compressing mono images by respecting mode to determi…
b6a0ea1 
…ne depth (#4847)

### What
 - Resolves: #4846

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4847/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4847/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4847/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4847)
- [Docs
preview](https://rerun.io/preview/deef4d8eb0369c94bbc7d29b100e021802e29c9b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/deef4d8eb0369c94bbc7d29b100e021802e29c9b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Fix support for compressing mono images by respecting mode to determine depth rerun-io/rerun
1 participant
@jleibs