Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename re_arrow_store to re_data_store #4672

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 4, 2024

Closes #4437

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🚜 refactor Change the code, not the functionality include in changelog labels Jan 4, 2024
@Wumpf Wumpf self-requested a review January 4, 2024 11:52
@Wumpf
Copy link
Member

Wumpf commented Jan 4, 2024

you removed all of re_arrow_store instead of renaming it ;)

@Wumpf Wumpf removed their request for review January 4, 2024 12:17
@emilk emilk force-pushed the emilk/rename-arrow-store branch from 724dea6 to 87346b3 Compare January 4, 2024 12:35
@Wumpf Wumpf self-requested a review January 4, 2024 12:40
@Wumpf Wumpf merged commit 790f391 into main Jan 4, 2024
40 checks passed
@Wumpf Wumpf deleted the emilk/rename-arrow-store branch January 4, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better naming and structure of the arrow/data/entity store/db
2 participants